Replace StandardCharset.UTF-8 with Charset.forName(“UTF-8”) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM; thanks |
|
@paddybyers what do you suggest we do about the build? Seems #330 is still a problem. @liuzhen2008 thanks very much for the contribution |
|
@liuzhen2008 just a quick update. We looked into what is causing the issues in the CI builds and should have a fix out for that soon (it was a Gradle compatibility issue). I will then rebase your changes on those fixes to make sure CI is not broken and merge this in and ensure we do a new release. Thanks again for this contribution. |
|
Thanks for this; merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Charset.forName directly.