New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL13b: ensure that detached+error responses form the server do not result in a busy loop of attach requests #411

Merged
merged 2 commits into from Jul 25, 2018

Conversation

3 participants
@paddybyers
Copy link
Member

paddybyers commented Jul 24, 2018

RTL13b: ensure that detached+error responses form the server do not r…
…esult in a busy loop of attach requests

@paddybyers paddybyers requested review from funkyboy and SimonWoolf Jul 24, 2018

@funkyboy
Copy link
Contributor

funkyboy left a comment

Looks good to me. Just two minor observations.

/* Send message error */
setDetached(e.errorInfo);
}
setDetached(e.errorInfo);

This comment has been minimized.

@funkyboy

funkyboy Jul 25, 2018

Contributor

Would it be worth adding a Log.d statement here?


} catch(AblyException e) {
e.printStackTrace();
fail("Unexpected exception");

This comment has been minimized.

@funkyboy

funkyboy Jul 25, 2018

Contributor

I'd add the function name here. The reader of CI logs will appreciate :)

This comment has been minimized.

@paddybyers

@funkyboy funkyboy merged commit d2762d1 into develop Jul 25, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@funkyboy funkyboy deleted the fix-rtl13 branch Jul 25, 2018

@SimonWoolf
Copy link
Member

SimonWoolf left a comment

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment