Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL13b: ensure that detached+error responses form the server do not result in a busy loop of attach requests #411

Merged
merged 2 commits into from Jul 25, 2018
Merged

RTL13b: ensure that detached+error responses form the server do not result in a busy loop of attach requests #411

merged 2 commits into from Jul 25, 2018

Conversation

paddybyers
Copy link
Member

funkyboy
funkyboy approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@funkyboy funkyboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just two minor observations.

lib/src/main/java/io/ably/lib/realtime/Channel.java Outdated
/* Send message error */
setDetached(e.errorInfo);
}
setDetached(e.errorInfo);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding a Log.d statement here?

lib/src/test/java/io/ably/lib/test/realtime/RealtimeChannelTest.java

} catch(AblyException e) {
e.printStackTrace();
fail("Unexpected exception");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add the function name here. The reader of CI logs will appreciate :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9800136

@funkyboy funkyboy merged commit d2762d1 into develop Jul 25, 2018
@funkyboy funkyboy deleted the fix-rtl13 branch July 25, 2018 11:36
SimonWoolf
SimonWoolf reviewed Jul 25, 2018
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf left review comments

@funkyboy funkyboy funkyboy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paddybyers @funkyboy @SimonWoolf