Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support outbound message extras #581

Merged
merged 24 commits into from
Jun 15, 2020
Merged

Support outbound message extras #581

merged 24 commits into from
Jun 15, 2020

Commits on Jun 10, 2020

  1. Add constructor to MessageExtras allowing it to be instantiated from … 

    …a JsonObject.

Some refactoring here to improve our use of gson also.
    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    a050229 View commit details
    Browse the repository at this point in the history

  2. Add instructions for running pure unit tests to the read me.

    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0f8ee1d View commit details
    Browse the repository at this point in the history

  3. Add unit test as basic smoke test for the new constructor.

    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    e8d9335 View commit details
    Browse the repository at this point in the history

  4. Implement equals and hashCode on MessageExtras and DeltaExtras.

    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    13dd407 View commit details
    Browse the repository at this point in the history

  5. Add unit test for the MessageExtras constructor that takes a DeltaExt… 

    …ras.
    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    00ad728 View commit details
    Browse the repository at this point in the history

  6. Refine existing unit test to validate that a MessageExtras instance c… 

    …reated from JSON does not return a delta extras instance.
    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f2cc321 View commit details
    Browse the repository at this point in the history

  7. Add unit test for MessagePack encode and decode of DeltaExtras within… 

    … MessageExtras.
    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    ef99b5b View commit details
    Browse the repository at this point in the history

  8. Add commentary.

    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f3dfaf9 View commit details
    Browse the repository at this point in the history

  9. Refactor the message pack support within the MessageExtras to support… 

    … bidirectional coding of 'raw' arbitrary JSON.
    Quintin Willison committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0752b58 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Remove misleading commentary.

    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    c56c859 View commit details
    Browse the repository at this point in the history

  2. Improve message extras hash and equality implementations so that, if … 

    …raw is available, they only use that value.

Also adds a toString, which assists with test debugging apart from anything else.
    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    8a65f7e View commit details
    Browse the repository at this point in the history

  3. Add integration test for RSL6a2. 

    It fails for the text protocol at the moment due to an issue with inbound JSON decoding.
    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    cb6bc7c View commit details
    Browse the repository at this point in the history

  4. Fix test now that MessageExtras quality check has been refactored to … 

    …only inspect raw if it's available.
    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    41d8857 View commit details
    Browse the repository at this point in the history

  5. Update gson dependency to latest release (October 2019), replacing th… 

    …e old version we had in place (November 2015).
    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    65b2b67 View commit details
    Browse the repository at this point in the history

  6. Simplify method names.

    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    d41635b View commit details
    Browse the repository at this point in the history

  7. Add SLF4J binding when running tests to help debugging.

    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    3cbb7d9 View commit details
    Browse the repository at this point in the history

  8. Add integration test for RSL6a2, covering the opaque case (raw JSON i… 

    …n message extras), fixing the implementation to support this.
    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    deb0f59 View commit details
    Browse the repository at this point in the history

  9. Revert some of the manual JSON deserialisation code I injected as it … 

    …was causing REST crypto tests for text protocol to fail.
    Quintin Willison committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    db2a17f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Make the API to obtain a JsonObject from a MessageExtras instance pub… 

    …lic.

Also:
- some renaming for clarity
- add code to the DeltaExtras constructor to ensure that a JsonObject is always available, making the asJsonObject method easier to reason about
    Quintin Willison committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    e41c806 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for constructor null arguments on MessageExtras.

    Quintin Willison committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    99e3407 View commit details
    Browse the repository at this point in the history

  3. Remove the unnecessary DeltaExtras constructor on MessageExtras.

    Quintin Willison committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    d6ff228 View commit details
    Browse the repository at this point in the history

  4. Remove DeltaExtras JSON serialisation support as it's not needed outb… 

    …ound.
    Quintin Willison committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    00f1167 View commit details
    Browse the repository at this point in the history

  5. Make the DeltaExtras constructor private as it's not needed in the pu… 

    …blic API.
    Quintin Willison committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    7fbc7b1 View commit details
    Browse the repository at this point in the history

  6. Fix oversight in my base message deserialisation code, covering the c… 

    …ase where a key is populated but with JSON null.
    Quintin Willison committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    5101238 View commit details
    Browse the repository at this point in the history