Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAP-49] no connection serials #1110

Merged
merged 33 commits into from
Jan 30, 2023
Merged

[CAP-49] no connection serials #1110

merged 33 commits into from
Jan 30, 2023

Commits on Jan 30, 2023

  1. http: fix http x-ably-version test ignoring headers

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8515af0 View commit details
    Browse the repository at this point in the history

  2. update ably protocol version to 2 (RSC7a)

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    633034e View commit details
    Browse the repository at this point in the history

  3. channel: fix channel serial type 

    Channel serials are string not numbers.
    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    b2a27eb View commit details
    Browse the repository at this point in the history

  4. channel: resume with attach 

    Rather than resuming by including a `connectionSerial` in the request,
which the backend uses to map the `connectionSerial` for the
`channelSerial` and resume those channels, instead the client just
reattaches each channel and includes the `channelSerial` in the`ATTACH`
request.
    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6394217 View commit details
    Browse the repository at this point in the history

  5. channel: remove checkChannelsOnResume check

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c74a354 View commit details
    Browse the repository at this point in the history

  6. connection: remove redundant reattach 

    Given we already re-attach all channels on a new connection this is
redundant.
    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    4fd8561 View commit details
    Browse the repository at this point in the history

  7. presence: include the member id in re-enter

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7d76878 View commit details
    Browse the repository at this point in the history

  8. presence: don't remove member on re-enter

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8b3b487 View commit details
    Browse the repository at this point in the history

  9. presence: store own members by clientId only

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    86072b1 View commit details
    Browse the repository at this point in the history

  10. presence: re-enter presence members even if in main presence set

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    58a03a8 View commit details
    Browse the repository at this point in the history

  11. presence: re-enter own members when moving into attached state

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    21e0f26 View commit details
    Browse the repository at this point in the history

  12. tsconfig: target es5

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    51dce34 View commit details
    Browse the repository at this point in the history

  13. connection: add createRecoveryKey

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    237c515 View commit details
    Browse the repository at this point in the history

  14. channel: fix channel options optional

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    20306f7 View commit details
    Browse the repository at this point in the history

  15. connection: recovery from new recovery key format

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c156ea0 View commit details
    Browse the repository at this point in the history

  16. connection: remove unsed setRecoveryKey

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2784464 View commit details
    Browse the repository at this point in the history

  17. upgrade: replace sync with activate

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    ddf0e7c View commit details
    Browse the repository at this point in the history

  18. connection: remove redundant connectionSerial

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    098de12 View commit details
    Browse the repository at this point in the history

  19. upgrade: don't wait for channel no pending before activating

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    d6a321d View commit details
    Browse the repository at this point in the history

  20. remove redundant duplicate message check 

    This is no longer needed in the new upgrade scheme.
    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    eac6c1b View commit details
    Browse the repository at this point in the history

  21. comet: fix comet connection key

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    904bdeb View commit details
    Browse the repository at this point in the history

  22. connection: remove redundant connectionKey test

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0193edb View commit details
    Browse the repository at this point in the history

  23. resume: update tested expected error code

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    46ffe64 View commit details
    Browse the repository at this point in the history

  24. upgrade: updated tested expected error code

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    412a96a View commit details
    Browse the repository at this point in the history

  25. upgrade: remove redundant unresponsive_upgrade_sync test 

    With protocol v2 we no longer wait for a `SYNC` so this test doesn't
make sense.
    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    35a1bdd View commit details
    Browse the repository at this point in the history

  26. upgrade: fix unrecoverableUpgrade upgrading before publishing

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    a122a2b View commit details
    Browse the repository at this point in the history

  27. connection: updated tested expected error code

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8b89cbe View commit details
    Browse the repository at this point in the history

  28. remove redundant duplicateConnectionId test

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f503f7d View commit details
    Browse the repository at this point in the history

  29. presence: update tests for new presence model

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9af4386 View commit details
    Browse the repository at this point in the history

  30. ConnectionManager: fix RTN19a2 implementation

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    faf621a View commit details
    Browse the repository at this point in the history

  31. resume: add recover test

    @andydunstall @SimonWoolf
    andydunstall authored and SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    4004274 View commit details
    Browse the repository at this point in the history

  32. Tests: fix flake/race in setOptionsCallbackBehaviour caused by protoc… 

    …ol v2
    @SimonWoolf
    SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    fe05647 View commit details
    Browse the repository at this point in the history

  33. init_usetokenauth_defaulttokenparams_wildcard test: increase ttl to f… 

    …ix race

with a 12s ttl, realtime was asking the lib to start a reauth as soon as
it connected. With unlucky timings, the original token details could be
cleared just before the test code looked at it.
    @SimonWoolf
    SimonWoolf committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    545ddbf View commit details
    Browse the repository at this point in the history