Make FetchRequest not try and parse a 204 response body
#1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently checks for the presence of a Content-Type response header and if present assumes that trying to parse the response will succeed. Realtime currently sends a 204 (No Content) with a Content-Type header from the POST rest.ably.io/push/publish endpoint when using HTTP 1.1 (see REA-1924). (This bug hasn't been caught by the tests because I guess most of the time they use HTTP 2 in browsers, and also we don't use FetchRequest in the tests except briefly in those for the modular variant of the library. I’ve created #1772 for improving this situation). The 204 handling approach is copied from that which we already have in XHRRequest. Resolves #1771.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently checks for the presence of a
Content-Typeresponse header and if present assumes that trying to parse the response will succeed.Realtime currently sends a
204 No Contentwith aContent-Typeheader from thePOST rest.ably.io/push/publishendpoint when using HTTP 1.1 (see REA-1924).(This bug hasn't been caught by the tests because I guess most of the time they use HTTP 2 in browsers, and also we don't use FetchRequest in the tests except briefly in those for the modular variant of the library. I’ve created #1772 for improving this situation).
The 204 handling approach is copied from that which we already have in
XHRRequest.Resolves #1771.