Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #152

Merged
merged 12 commits into from May 27, 2022
Merged

Refactor code #152

merged 12 commits into from May 27, 2022

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Apr 18, 2022

No description provided.

Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one minor nitpick 🙂 CI is failing for PHP 7.2 and 7.3, could you take a look and re-run if it's just flakiness?

src/AblyRest.php Outdated Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from owenpearson May 20, 2022 09:31
@sacOO7 sacOO7 marked this pull request as ready for review May 20, 2022 09:31
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@owenpearson owenpearson merged commit 1bbfec0 into main May 27, 2022
@owenpearson owenpearson deleted the fix/refactoring branch May 27, 2022 21:31
@AmirQSD AmirQSD mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants