Rsc1 api constructor #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattheworiordan please take a look at this PR too |
set of ClientOptions. Now raises an exception o on instantiation if there is no way to authenticate.
AblyRest __init__ format.
aericson
force-pushed
the
rsc1-api-constructor
branch
from
33c31a3
to
3924b96
Compare
|
@mattheworiordan: updated. Can you take another look? I have rebased to update code from fjsj's last PR, your past comments wont show here. You can find them here if you need: vintasoftware@1e1eae2#comments |
| self.assertEqual(ably.options.key_name, test_vars["keys"][0]["key_name"], | ||
| "Key id does not match") | ||
| self.assertEqual(ably.options.key_secret, test_vars["keys"][0]["key_secret"], | ||
| "Key value does not match") |
There was a problem hiding this comment.
I will merge, and not that important really, but the test text still refers to key id and key value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(RSC1) The constructor accepts either an API key, a token string, or a set of ClientOptions. An exception is raised if invalid arguments are provided such as no API key, token and no means to create a token.