1.0 release #111
Merged
1.0 release #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously failing in CI because of basic auth credentials in the URL in 1.x and in a header in 2.x
Sublime issue…
… be published (RTL11)
Instead MsgPack & JSON builds will now be run concurrently getting around the max time limit being hit
/app/lib/ably/models/message_encoders/base.rb:10:in `<top (required)>': uninitialized constant Ably::Models (NameError)
When a WS transport becomes disconnected, if the connection state is suspended there is nothing to do
If a method is invoked and it’s failure / success is determined by the client library’s state, then the deferrable errback should always be used i.e. a developer can then reliably always use errback and callback to deal with failure & success respectively. Exceptions are now only raised when a method is called with invalid arguments.
Normally once the ACK is received the message has been sent to the client. But this is not always the case and in some situations the enter arrived later thus causing the test assertions to fail expecting a later message.
…d to have expired
If waitForSync is true, then an error is generated when get is called as the presence map is out of sync at this point.
#RSA5, #RSA6, #TK2a, #TK2b
I incorrectly assumed messages always came before ACKs, but this is no longer the case. This ensures we remove that assumption
mattheworiordan
force-pushed
the
1-0-master
branch
from
ce51018
to
5ff685a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes the working version #99
Complete spec at ably/docs#260