Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TO3l9 Max frame size #259

Merged
merged 2 commits into from Jul 26, 2021
Merged

TO3l9 Max frame size #259

merged 2 commits into from Jul 26, 2021

Conversation

lukaszsliwa
Copy link
Contributor

Resolves #245

Checking body size in the Ably::Rest::Client#request (for :post, :patch, :put methods only).

@lukaszsliwa lukaszsliwa self-assigned this Jul 14, 2021
owenpearson
owenpearson approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

@owenpearson owenpearson merged commit 6ef1485 into main Jul 26, 2021
@owenpearson owenpearson deleted the TO3l9 branch July 26, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees

@lukaszsliwa lukaszsliwa

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update client options support to 1.1 spec level (maxFrameSize)
2 participants
@lukaszsliwa @owenpearson