Add all 3 callbacks for activation lifecycle (2 were missing) & update to latest ably-cocoa API #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify setting the delegate manually
marklewin
suggested changes
Aug 23, 2021
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
|
Thanks @marklewin , I've committed all your suggestions as they make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 callback events for push devices: activate, deactivate and update failed. 2 were missing.
In the objective-C and Swift code blocks, I also set the delegate manually, because this is the non-legacy API, as per the internal code of Ably-cocoa (not documented anywhere 馃槀). The automatic delegate has the variable name
legacyDelegate.To see the preview, visit https://ably-docs-pr-1177.herokuapp.com/general/push/activate-subscribe/ and go to
Handle push notification lifecycle.