Make Locks.prototype.getLocksForConnectionId private
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on MMB-156 I asked whether this was meant to be part of the public API and was told no, and that its usage should be replaced by Locks.prototype.getSelf. I have no idea whether the `delay(60)` preceding the call to releaseMyLocks in the useElementSelect hook is still necessary, since I don’t know what the "spaces API" that it refers to is.
lawrence-forooghian
force-pushed
the
remove-getLocksForConnectionId-from-demo-code
branch
from
e28448c
to
528dd50
Compare
dpiatek
approved these changes
Sep 25, 2023
lawrence-forooghian
deleted the
remove-getLocksForConnectionId-from-demo-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on MMB-156 I asked whether this was meant to be part of the public API and was told no, and that its usage should be replaced by
Locks.prototype.getSelf.I have no idea whether the
delay(60)preceding the call toreleaseMyLocksin theuseElementSelecthook is still necessary, since I don’t know what the "spaces API" that it refers to is.