Better handling of crash report without test failure

Return a 400 response with a useful error message.

Part of #73.

src/uploads/postUploads.controller.ts

@@ -14,7 +14,12 @@ import {
   ValidateNested,
 } from 'class-validator';
 import { Type } from 'class-transformer';
-import { UploadCreationCrashReport, UploadsService } from './uploads.service';
+import {
+  CrashReportWithoutFailureError,
+  UploadCreationCrashReport,
+  UploadsService,
+} from './uploads.service';
+import { Upload } from './upload.entity';
 
 class CreateUploadDTO {
   @IsString()
@@ -122,24 +127,32 @@ export class PostUploadsController {
       }));
     }
 
-    const upload = await this.uploadsService.create(
-      {
-        junitReportXml,
-        githubRepository: body.github_repository,
-        githubSha: body.github_sha,
-        githubRefName: body.github_ref_name,
-        githubRetentionDays: body.github_retention_days,
-        githubAction: body.github_action,
-        githubRunNumber: body.github_run_number,
-        githubRunAttempt: body.github_run_attempt,
-        githubRunId: body.github_run_id,
-        githubBaseRef: body.github_base_ref,
-        githubHeadRef: body.github_head_ref,
-        githubJob: body.github_job,
-        iteration: body.iteration,
-      },
-      crashReports,
-    );
-    return { id: upload.id };
+    try {
+      const upload = await this.uploadsService.create(
+        {
+          junitReportXml,
+          githubRepository: body.github_repository,
+          githubSha: body.github_sha,
+          githubRefName: body.github_ref_name,
+          githubRetentionDays: body.github_retention_days,
+          githubAction: body.github_action,
+          githubRunNumber: body.github_run_number,
+          githubRunAttempt: body.github_run_attempt,
+          githubRunId: body.github_run_id,
+          githubBaseRef: body.github_base_ref,
+          githubHeadRef: body.github_head_ref,
+          githubJob: body.github_job,
+          iteration: body.iteration,
+        },
+        crashReports,
+      );
+
+      return { id: upload.id };
+    } catch (err) {
+      if (err instanceof CrashReportWithoutFailureError) {
+        throw new HttpException(err.message, HttpStatus.BAD_REQUEST);
+      }
+      throw err;
+    }
   }
 }

src/uploads/uploads.service.ts

@@ -24,6 +24,8 @@ export interface UploadCreationCrashReport {
   data: Buffer;
 }
 
+export class CrashReportWithoutFailureError extends Error {}
+
 @Injectable()
 export class UploadsService {
   constructor(
@@ -126,8 +128,8 @@ export class UploadsService {
       );
 
       if (!failure) {
-        throw new Error(
-          `No failure found with testClassName ${uploadCreationCrashReport.testClassName} and testCaseName ${uploadCreationCrashReport.testCaseName}`,
+        throw new CrashReportWithoutFailureError(
+          `There is no test failure corresponding to the crash report with testClassName ${uploadCreationCrashReport.testClassName} and testCaseName ${uploadCreationCrashReport.testCaseName}`,
         );
       }