Store URL of the GitHub job that performed upload #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new github_job_html_url and github_job_api_url parameters to the create upload endpoint, and save them on the upload. Add a link to the github_job_html_url on the upload details page. See ably/test-observability-action#20 for an example of specifying these new parameters.
lawrence-forooghian
force-pushed
the
link-to-job
branch
from
b97b8a5
to
79e47ea
Compare
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new
github_job_html_urlandgithub_job_api_urlparameters to the create upload endpoint, and saves them on the upload. It then adds a link to thegithub_job_html_urlon the upload details page.See ably/test-observability-action#20 for an example of specifying these new parameters.
Here's an example of the UI looks now with some dummy data (see the new "GitHub job URL" field):