Refactor docstrings and filter item list

abmmhasan · Dec 7, 2023 · 4fb1d30 · 4fb1d30
1 parent b1e5680
commit 4fb1d30
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Draw/GrandDraw.php b/src/Draw/GrandDraw.php
@@ -15,7 +15,7 @@ class GrandDraw
      * Sets the file path for the user list.
      *
      * @param string $userListFilePath The file path for the user list.
-     * @return GrandDraw Returns the BucketDraw instance.
+     * @return GrandDraw Returns the instance.
      * @throws Exception If the file does not exist.
      */
     public function setUserListFilePath(string $userListFilePath): GrandDraw
@@ -32,7 +32,7 @@ public function setUserListFilePath(string $userListFilePath): GrandDraw
      * Sets the items for the BucketDraw object.
      *
      * @param array $items The array of items to be set.
-     * @return GrandDraw The updated BucketDraw object.
+     * @return GrandDraw The updated object.
      */
     public function setItems(array $items): GrandDraw
     {

diff --git a/src/Draw/LuckyDraw.php b/src/Draw/LuckyDraw.php
@@ -42,7 +42,7 @@ private function check(): void
     public function pick(bool $check = true): array
     {
         $check && $this->check();
-        $items = array_column($this->items, 'chances', 'item');
+        $items = array_filter(array_column($this->items, 'chances', 'item'));
         $items = $this->prepare($items);
         $pickedItem = $this->draw($items);
         $amounts = $this->items[array_search($pickedItem, array_column($this->items, 'item'))]['amounts'];