Provide ace-window-posframe-mode

[notmgsk]

Use posframes for overlays.

There does seem to be a slight but noticable delay when displaying the posframes. Haven't investigated too much into why.

[abo-abo]

Thanks. Looks good. Do you have an Emacs Copyright Assignment? Both ace-window and posframe are on https://elpa.gnu.org/packages/.

[notmgsk]

Working on it. Will let you know once it's done.

[abo-abo]

Thanks in advance.

[obar]

I'm using this with (set-face-attribute 'aw-leading-char-face nil :weight 'bold :height 2.0) and the height scale in particular makes the labels stand out. I think it's probably too opinionated to set as a default, but perhaps it warrants inclusion in an example adjacent to the documentation for ace-window-posframe-mode in the eventual readme.

This is a useful patch for a great package! Thanks to you both.

[loafofpiecrust]

I'm excited to have this functionality in ace-window mainly for use with exwm. For that, though, I need to add the (parent-frame . nil) parameter to posframes. So a defcustom aw-posframe-parameters would be lovely.

[tumashu]

does (parent-frame . nil) work well?

[omar-polo]

Sorry for my ignorance, but while trying this I got an error about map not being defined. I don't know which package should provide this (I tried to install and load a package called "map", but it didn't work). A simpler

(mapcar #'posframe-delete aw--posframe-frames)

seems to work. (I only did some quick testing).

Another thing is that using your fork, posframe is not listed as dependency (or at least straight.el doesn't think it is -- I am not yet aware of how dependencies are declared and consumed.)

Anyway, thanks for this feature, is awesome :)

[notmgsk]

@abo-abo Finally I have the copyright assignment. I'm going to take a look at this again, and address the comments above.

[gcv]

@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).

[notmgsk]

@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).

Thanks. The lazy approach is already implemented, and has been sufficient for my usage.

[tumashu]

maybe better?

 (bufname (format " *aw-posframe-buffer-%s*" path))) 

[josephmturner]

Hello! Thank you for ace-window! Is there a reason to not merge this PR?

[abo-abo]

Merged. Thanks @notmgsk for the contribution. And to everyone who reviewed. And @josephmturner for the ping.

[josephmturner]

@abo-abo @notmgsk Thank you!! This will make ace-window work much better with EXWM.