Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize load time. #426

Closed
wants to merge 1 commit into from
Closed

Optimize load time. #426

wants to merge 1 commit into from

Conversation

mookid
Copy link
Contributor

@mookid mookid commented Apr 25, 2018

On my machine the load time (of the whole emacs!) goes from 3.5s to 2.2s.

see #421

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.415% when pulling 84805c1 on mookid:master into be5f166 on abo-abo:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.415% when pulling 84805c1 on mookid:master into be5f166 on abo-abo:master.

@abo-abo
Copy link
Owner

abo-abo commented Apr 26, 2018

Hmm. The improvement in start-up time may be there. But after re-compiling and restarting C-2 gives me:

command-execute: Wrong type argument: commandp, lispy-arglist-inline

Further, e gives me:

lispy--eval-default: Symbol's value as variable is void: lispy-elisp-modes

Your PR is a good effort, but still needs work, like adding ;;;###autoload where needed, moving some require to the function body that uses it etc.

@mookid
Copy link
Contributor Author

mookid commented Apr 26, 2018

I have issues testing it, because make all fails. I'll retry a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants