Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<C-u> (prefix argument) counsel-rg signals errors when called from an active ivy-occur buffer #1866

Closed
Alexander-Shukaev opened this issue Dec 20, 2018 · 5 comments

Comments

@Alexander-Shukaev
Copy link

@Alexander-Shukaev Alexander-Shukaev commented Dec 20, 2018

C-u M-x counsel-rg:

  • Choose a directory, e.g. .emacs.d/, RET;
  • Empty args, RET;
  • Type some valid pattern and see error occur while typing, nothing matched;
  • In *Messages*: Error in post-command-hook (ivy--queue-exhibit): (file-missing "Setting current directory" "No such file or directory" #(".emacs.d/" 0 9 (dirp t))).
@mookid
Copy link
Contributor

@mookid mookid commented Dec 20, 2018

I can't reproduce.

Can you please precise if the pattern is supposed to match?

@Alexander-Shukaev
Copy link
Author

@Alexander-Shukaev Alexander-Shukaev commented Dec 20, 2018

I think I know what the trigger is. You should perform all these actions while ivy-occur buffer's window is current. ROFL 🥇

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Dec 22, 2018

  1. make plain

  2. C-ckcounsel-rgC-cC-o

  3. C-uC-ck

    3

    Note how the current directory is not shown after the prompt.

  4. C-g

  5. M-:(read-directory-name "")RET

    5

    Once again, note how the current directory is not shown after the prompt.

  6. C-gC-xo

  7. Repeat step 5.

    7

    Note how the current directory is shown after the prompt.

  8. Repeat step 6.

  9. Repeat step 5.

    9

    Note how the current directory has magically appeared after the prompt this time.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Dec 22, 2018

I think I know what the trigger is. You should perform all these actions while ivy-occur buffer's window is current.

Can the issue title please be updated accordingly? E.g. "counsel-rg with prefix arg in ivy-occur buffer signals error" or similar.

@Alexander-Shukaev Alexander-Shukaev changed the title <C-u> counsel-rg signals errors <C-u> (prefix argument) counsel-rg signals errors when called from an active ivy-occur buffer Dec 22, 2018
@abo-abo abo-abo closed this in 3a16cec May 8, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 8, 2019

Thanks, please test.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
We have `ivy-state-directory' anyway.

Fixes abo-abo#1866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants