New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the portion of the line that matches the current query #212

Closed
Wilfred opened this Issue Aug 28, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@Wilfred
Contributor

Wilfred commented Aug 28, 2015

swiper

In this picture, my second line actually matches my search term twice. However, because the line is quite long, it's easy not to notice.

I think swiper should highlight the matching part of the line, so it's clear that there are multiple matches on the current line.

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Aug 28, 2015

Owner

You mean in the minibuffer? Because it already highlights it in the main buffer.

Owner

abo-abo commented Aug 28, 2015

You mean in the minibuffer? Because it already highlights it in the main buffer.

@Wilfred

This comment has been minimized.

Show comment
Hide comment
@Wilfred

Wilfred Aug 28, 2015

Contributor

Yep, in the minibuffer. The results currently visible in the minibuffer are not necessarily all visible in the buffer (depending on how close together the results are).

I thought I'd file a bug because this caught me out today when looking through a large buffer code.

Contributor

Wilfred commented Aug 28, 2015

Yep, in the minibuffer. The results currently visible in the minibuffer are not necessarily all visible in the buffer (depending on how close together the results are).

I thought I'd file a bug because this caught me out today when looking through a large buffer code.

@abo-abo abo-abo closed this in 8d754de Sep 3, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Sep 3, 2015

Owner

Thanks, please test the new feature with:

(setq ivy-display-style 'fancy)
Owner

abo-abo commented Sep 3, 2015

Thanks, please test the new feature with:

(setq ivy-display-style 'fancy)
@Wilfred

This comment has been minimized.

Show comment
Hide comment
@Wilfred

Wilfred Sep 3, 2015

Contributor

Works perfectly. Thank you :)

Contributor

Wilfred commented Sep 3, 2015

Works perfectly. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment