Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is ivy-avy.el not byte-compiled? #2574

Open
basil-conto opened this issue May 22, 2020 · 4 comments · May be fixed by #2917
Open

Why is ivy-avy.el not byte-compiled? #2574

basil-conto opened this issue May 22, 2020 · 4 comments · May be fixed by #2917
Labels
question regression

Comments

@basil-conto
Copy link
Collaborator

make compile does not currently byte-compile ivy-avy.el. Is this intentional? If so, why?
@kiennq
Copy link
Contributor

kiennq commented May 22, 2020

I think ivy-avy just got extracted, and now even the define-key for it is not working.

@basil-conto basil-conto mentioned this issue May 27, 2020
Open
@basil-conto
Copy link
Collaborator Author

Thanks @abo-abo, but that change seems to have caused worse problems (#2583) without addressing the comment by @kiennq:

now even the define-key for it is not working.

@basil-conto basil-conto reopened this May 27, 2020
@abo-abo
Copy link
Owner

abo-abo commented Jun 8, 2020

@kiennq Please test the following:

(require 'ivy)
(require 'ivy-avy)

There's also a submitted proposal for an ivy-avy package on MELPA. I'll message here once it's available.

abo-abo added a commit that referenced this issue Jun 8, 2020
@abo-abo
targets/plain.el: Require ivy-avy
39ede5f 
Note: "make deps" needs to be run to install/update avy.

Re #2574
@kiennq
Copy link
Contributor

kiennq commented Jun 8, 2020

@kiennq Please test the following:

(require 'ivy)
(require 'ivy-avy)

There's also a submitted proposal for an ivy-avy package on MELPA. I'll message here once it's available.

That's what I'm using now, however, having 'ivy-avy autoloaded seems to be a better solution?

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
@abo-abo @astoff
Makefile: Compile ivy-avy.el
d4f2c93 
Make sure to run "make deps" once beforehand.

Fixes abo-abo#2574
astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
@abo-abo @astoff
targets/plain.el: Require ivy-avy
02ae539 
Note: "make deps" needs to be run to install/update avy.

Re abo-abo#2574
basil-conto added a commit that referenced this issue Sep 22, 2021
@basil-conto
Reabsorb ivy-avy into ivy
04e813a 
For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

* ivy-avy.el: Move contents to ivy.el, and move empty package...
* obsolete/ivy-avy.el: ...here.

* ivy.el: Bump package version to 0.13.5.
(ivy-define-key): Use function-put in place of put.
(ivy-minibuffer-map): Bind ivy-avy.
(ivy-avy-style): Moved from ivy-avy.el.  Add a nil option for
falling through to the default avy-styles-alist or avy-style.
(ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
(ivy-avy): Moved from ivy-avy.el with some cleanups.

* swiper.el: Bump package versions to 0.13.5.
Localize external variable and function declarations.
(swiper-avy): Fix error message and docstring.

* counsel.el:
* ivy-hydra.el
* doc/ivy.org: Bump package versions to 0.13.5.
* doc/ivy.texi: Regenerate.

* Makefile (compile): Don't byte-compile ivy-avy.el.
* ivy-test.el (ivy-avy):
* targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.
basil-conto added a commit that referenced this issue Sep 22, 2021
@basil-conto
Reabsorb ivy-avy into ivy
50798e8 
For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

* ivy-avy.el: Move contents to ivy.el.  Bump package versions to
0.13.5.  Mention deprecation in Commentary and warning message.

* ivy.el: Bump package version to 0.13.5.
(ivy-define-key): Use function-put in place of put.
(ivy-minibuffer-map): Bind ivy-avy.
(ivy-avy-style): Moved from ivy-avy.el.  Add a nil option for
falling through to the default avy-styles-alist or avy-style.
(ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
(ivy-avy): Moved from ivy-avy.el with some cleanups.

* swiper.el: Bump package versions to 0.13.5.
Localize external variable and function declarations.
(swiper-avy): Fix error message and docstring.

* counsel.el:
* ivy-hydra.el
* doc/ivy.org: Bump package versions to 0.13.5.
* doc/ivy.texi: Regenerate.

* Makefile (compile): Don't byte-compile ivy-avy.el.
* ivy-test.el (ivy-avy):
* targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.
basil-conto added a commit that referenced this issue Sep 22, 2021
@basil-conto
Reabsorb ivy-avy into ivy
b203e30 
For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

* ivy-avy.el: Move contents to ivy.el.  Bump package versions to
0.13.5.  Mention deprecation in Commentary and warning message.

* ivy.el: Bump package version to 0.13.5.
(ivy-define-key): Use function-put in place of put.
(ivy-minibuffer-map): Bind ivy-avy.
(ivy-avy-style): Moved from ivy-avy.el.  Add a nil option for
falling through to the default avy-styles-alist or avy-style.
(ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
(ivy-avy): Moved from ivy-avy.el with some cleanups.

* swiper.el: Bump package versions to 0.13.5.
Localize external variable and function declarations.
(swiper-avy): Fix error message and docstring.

* counsel.el:
* ivy-hydra.el
* doc/ivy.org: Bump package versions to 0.13.5.
* doc/ivy.texi: Regenerate.

* Makefile (compile): Don't byte-compile ivy-avy.el.
* ivy-test.el (ivy-avy):
* targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.
@basil-conto basil-conto linked a pull request Sep 22, 2021 that will close this issue
Draft
basil-conto added a commit that referenced this issue Sep 29, 2021
@basil-conto
Reabsorb ivy-avy into ivy
52b5db5 
For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

* ivy-avy.el: Move contents to ivy.el.  Bump package versions to
0.13.5.  Mention deprecation in Commentary and warning message.

* ivy.el: Bump package version to 0.13.5.
(ivy-define-key): Use function-put in place of put.
(ivy-minibuffer-map): Bind ivy-avy.
(ivy-avy-style): Moved from ivy-avy.el.  Add a nil option for
falling through to the default avy-styles-alist or avy-style.
(ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
(ivy-avy): Moved from ivy-avy.el with some cleanups.

* swiper.el: Bump package versions to 0.13.5.
Localize external variable and function declarations.
(swiper-avy): Fix error message and docstring.

* counsel.el:
* ivy-hydra.el
* doc/ivy.org: Bump package versions to 0.13.5.
* doc/ivy.texi: Regenerate.

* Makefile (compile): Don't byte-compile ivy-avy.el.
* ivy-test.el (ivy-avy):
* targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.
basil-conto added a commit that referenced this issue Sep 30, 2021
@basil-conto
Reabsorb ivy-avy into ivy
82d9306 
For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

* ivy-avy.el: Move contents to ivy.el.  Bump package versions to
0.13.5.  Mention deprecation in Commentary and warning message.

* ivy.el: Bump package version to 0.13.5.
(ivy-define-key): Use function-put in place of put.
(ivy-minibuffer-map): Bind ivy-avy.
(ivy-avy-style): Moved from ivy-avy.el.  Add a nil option for
falling through to the default avy-styles-alist or avy-style.
(ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
(ivy-avy): Moved from ivy-avy.el with some cleanups.

* swiper.el: Bump package versions to 0.13.5.
Localize external variable and function declarations.
(swiper-avy): Fix error message and docstring.

* counsel.el:
* ivy-hydra.el
* doc/ivy.org: Bump package versions to 0.13.5.
* doc/ivy.texi: Regenerate.

* Makefile (compile): Don't byte-compile ivy-avy.el.
* ivy-test.el (ivy-avy):
* targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reabsorb ivy-avy into ivy abo-abo/swiper
3 participants
@kiennq @abo-abo @basil-conto