counsel-M-x: this-command is incorrect in minibuffer-setup-hook

[gexplorer]

When executing the command counsel-M-x, the value of the variable this-command in the hook minibuffer-setup-hook is the previously executed command instead of counsel-M-x.

[basil-conto]

See #891. Ccing @Wilfred.

[gexplorer]

Those two lines are precisely the ones causing the strange behavior I noticed.

I created this snippet to test it easily.

The problem is that even though when executing the target command the values of this-command and last-command are correct, during the hook minibuffer-setup-hook when executing counsel-M-x all values get replaced.

When executing ‘execute-extended-command‘

• minibuffer-setup-hook

command	value	real value
this	eval-last-sexp	eval-last-sexp
last	move-end-of-line	move-end-of-line

• gx-debug-commands

command	value	real value
this	gx-debug-commands	gx-debug-commands
last	self-insert-command	self-insert-command

When executing ‘counsel-M-x‘

• minibuffer-setup-hook

command	value	real value
this	mouse-set-point	mouse-set-point
last	mouse-set-point	mouse-set-point

• gx-debug-commands

command	value	real value
this	gx-debug-commands	gx-debug-commands
last	self-insert-command	self-insert-command