New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features on swiper #319

Closed
emacsuser123 opened this Issue Dec 10, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@emacsuser123

emacsuser123 commented Dec 10, 2015

Hi.

First of all, thanks for this package. I think it is really useful. The space-based regular expression matching is very handy at any time.
I use swiper in place of the native search system in emacs.

However, there's a couple of features that I miss:

  • Search should be made cyclic. Once you have reached the end of the list of occurrences, the user should be notified with something like "end of list" and, if the user keeps pressing C-s or C-n, the app should take her back to the first occurrence.
    This is applicable to both forward-searches and backward-searches.
  • Backward searching seems a bit counter-intuitive. Let's say that the point is at the very end of the document. If you try to search backwards, it performs a forward search, instead, and starting the search at the very beginning of the document.

I think these two features are quite important, since that is the native behavior of the emacs search system, and I believe it helps users a lot.

Thanks.
-Bob

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Dec 10, 2015

Owner

Search should be made cyclic

Use (setq ivy-wrap t).

Backward searching seems a bit counter-intuitive.

There's no backward or forward searching implemented: the search is in the whole document at once.

Owner

abo-abo commented Dec 10, 2015

Search should be made cyclic

Use (setq ivy-wrap t).

Backward searching seems a bit counter-intuitive.

There's no backward or forward searching implemented: the search is in the whole document at once.

@emacsuser123

This comment has been minimized.

Show comment
Hide comment
@emacsuser123

emacsuser123 Dec 10, 2015

Hi.

Thanks for the promp response.

With regard to the cyclic behavior:
OK, I have set the ivy-wrap flag to true, and now the search is cyclic. Thanks a lot.

With respect to the backward search ...
understood. Are there any plans to implement it?

Thanks a lot.
-Bob

emacsuser123 commented Dec 10, 2015

Hi.

Thanks for the promp response.

With regard to the cyclic behavior:
OK, I have set the ivy-wrap flag to true, and now the search is cyclic. Thanks a lot.

With respect to the backward search ...
understood. Are there any plans to implement it?

Thanks a lot.
-Bob

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Dec 10, 2015

Owner

Are there any plans to implement it?

There's nothing to implement, as far as I see. The current approach works as intended.

Owner

abo-abo commented Dec 10, 2015

Are there any plans to implement it?

There's nothing to implement, as far as I see. The current approach works as intended.

@josuah

This comment has been minimized.

Show comment
Hide comment
@josuah

josuah Dec 27, 2015

It seems that forward/backward are done with C-n C-p, so a call to swiper (C-s) then C-p would select the same element as C-r did?

Maybe unless there are no matches forward, where the first backward match may be picked instead.

josuah commented Dec 27, 2015

It seems that forward/backward are done with C-n C-p, so a call to swiper (C-s) then C-p would select the same element as C-r did?

Maybe unless there are no matches forward, where the first backward match may be picked instead.

@abo-abo abo-abo closed this in bcb81dd Jan 18, 2016

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jan 18, 2016

Owner

Thanks, I finally understood what you meant by the "backward" search.

Owner

abo-abo commented Jan 18, 2016

Thanks, I finally understood what you meant by the "backward" search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment