Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-geiser-doc-look-up-manual): Add. #2235

Closed
wants to merge 1 commit into from

Conversation

leungbk
Copy link
Contributor

@leungbk leungbk commented Sep 18, 2019

No description provided.

@abo-abo
Copy link
Owner

abo-abo commented Oct 2, 2019

Thanks. Looks useful. But I don't want counsel depending on private symbols from Geiser. Could you please request/PR for something like:

  • geiser-symbols-list
  • geiser-doc-for-symbol

@leungbk
Copy link
Contributor Author

leungbk commented Nov 18, 2019

OK, the requisite commits to Geiser for the newly exposed geiser-doc-manual-for-symbol and geiser-completion-symbol-list-func have now been merged. I've updated this PR accordingly.

@abo-abo abo-abo closed this in a7ae5f0 Nov 18, 2019
@abo-abo
Copy link
Owner

abo-abo commented Nov 18, 2019

Thanks.

@leungbk leungbk deleted the counsel-geiser-doc branch November 20, 2019 17:55
astoff pushed a commit to astoff/swiper that referenced this pull request Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants