ivy-occur: set next-error-function. #2257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ivy.el (ivy-occur): set next-error-last-buffer. This change allows to use next-error and previous-error as a replacement for ivy-occur-toggle-calling, ivy-occur-next-line and ivy-occur-previous-line. For example with next-error and bound to M-n and M-p: - "C-h f" (`describe-funtion') - "run" (`self-insert-command') - "C-c C-o" (`ivy-occur'); "C-o u" also works. - "M-n M-n M-n M-k M-k M-k"
|
To see an example where this change is particularly significant, call ivy-occur once (1), set next-error to target the buffer corresponding to the results of (1) (for instance, press With occur or with ivy-occur with the changes in that PR, next-error focus results of (2) (which is expected) while with ivy-occur on master, we keep hitting results of (1). |
* swiper.el (swiper-occur): use ivy-occur-next-error. This change ensures that next-error and previous-error work for swiper even for buffer that do not visit a file.
|
Thanks. Your example wasn't working for me until the follow-up commit. |
|
Thanks! I think it also closes #1353. |
astoff
pushed a commit
to astoff/swiper
that referenced
this issue
Jan 1, 2021
* ivy.el (ivy-occur-next-error): Add. This change ensures that next-error and previous-error work for swiper even for buffer that do not visit a file. Fixes abo-abo#2257 Fixes abo-abo#1354
astoff
pushed a commit
to astoff/swiper
that referenced
this issue
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This set of changes allows to use next-error and previous-error
as a replacement for ivy-occur-toggle-calling, ivy-occur-next-line
and ivy-occur-previous-line.
For example with next-error and bound to M-n and M-p:
this problem seems to be like #1353.
also see commit 1c45b29.
NOTE: the existing pop-to-buffer at the end of ivy-occur makes the UI of ivy-occur different from occur; this PR aims at getting ivy-occur closer to occur in that regards.
@abo-abo please let me know if that is of interest, this can probably be extended.
The second commit happens to fix #1354.