chore(ci): fix failure detection

abougouffa · Oct 22, 2023 · 9b63d42 · 9b63d42
1 parent a4f95c8
commit 9b63d42
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci-linux.yaml b/.github/workflows/ci-linux.yaml
@@ -40,7 +40,7 @@ jobs:
           MINEMACSDIR=.github/workflows/scripts/minemacs-all.d/
           make ci | tee /tmp/minemacs-output
           EMACS_EXIT_CODE=$?
-          if [[ $EMACS_EXIT_CODE == 0 ]]; then
+          if [[ "$EMACS_EXIT_CODE" == 0 ]]; then
             echo "Emacs exited successfully"
           else
             echo "Emacs exited with non-zero code ${EMACS_EXIT_CODE}"
@@ -58,5 +58,5 @@ jobs:
           if [[ ! -z "$WARNINGS" ]]; then
             echo -e "## Warnings\n$WARNINGS" >> $GITHUB_STEP_SUMMARY
           fi
-          if [[ ! -z "$LOAD_ERRORS" ]] || [[ ! -z "$ELISP_ERRORS" ]] || [[ ! -z "$EMACS_EXIT_CODE" ]]; then exit 1; fi
+          if [[ ! -z "$LOAD_ERRORS" ]] || [[ ! -z "$ELISP_ERRORS" ]] || [[ "$EMACS_EXIT_CODE" != 0 ]]; then exit 1; fi
 
diff --git a/.github/workflows/ci-macos.yaml b/.github/workflows/ci-macos.yaml
@@ -35,7 +35,7 @@ jobs:
           MINEMACSDIR=.github/workflows/scripts/minemacs-all.d/
           make ci | tee /tmp/minemacs-output
           EMACS_EXIT_CODE=$?
-          if [[ -z "$EMACS_EXIT_CODE" ]]; then
+          if [[ "$EMACS_EXIT_CODE" == 0 ]]; then
             echo "Emacs exited successfully"
           else
             echo "Emacs exited with non-zero code ${EMACS_EXIT_CODE}"
@@ -53,4 +53,4 @@ jobs:
           if [[ ! -z "$WARNINGS" ]]; then
             echo -e "## Warnings\n$WARNINGS" >> $GITHUB_STEP_SUMMARY
           fi
-          if [[ ! -z "$LOAD_ERRORS" ]] || [[ ! -z "$ELISP_ERRORS" ]] || [[ ! -z "$EMACS_EXIT_CODE" ]]; then exit 1; fi
+          if [[ ! -z "$LOAD_ERRORS" ]] || [[ ! -z "$ELISP_ERRORS" ]] || [[ "$EMACS_EXIT_CODE" != 0 ]]; then exit 1; fi