122 feat cross linking with glossary file globs #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tle' will be ignored). If 'file' is a glob pattern 'termHint' and 'title' will be ignored. There are various reasons for this. First is performance. For each file terminator had to scan the 'glossaries' array for entries with a glob pattern and test whether the current entry is the one matching the file being processed in order to apply the correct 'termHint' and 'title'. Second: if there were two patterns matching the same file it would not be possible to decide which 'termHint' to apply. Basically 'termHint' loses its original purpose, anyways, if there are multiple files using the same term hint. Third: glob patterns are being introduced to support cross-linking. Unlike the option's name suggests documents being matched are no longer glossaries, only but any document. Headings are no longer terms but headings being processed like terms. So 'termHint' isn't a hint on a term anymore.
about-code
deleted the
122-feat-cross-linking-with-glossary-file-globs
branch
about-code
added a commit
that referenced
this pull request
Dec 28, 2020
…glossaries[i].file` config is a glob. Regression related to #133 commit d34feaf721bf83b73157404658d589681cd590e1 Author: about-code <6525873+about-code@users.noreply.github.com> Date: Sun Dec 27 22:35:52 2020 +0100 test: New baseline. commit 40a798113f944d0a96ce00598e105c40bf4ae85c Author: about-code <6525873+about-code@users.noreply.github.com> Date: Sun Dec 27 22:32:27 2020 +0100 test: Add test case commit 9aa55b06c4f59c6a2b1bf247f9a392a16096ab98 Author: about-code <6525873+about-code@users.noreply.github.com> Date: Sun Dec 27 22:01:55 2020 +0100 fix: Wrong link to glossary definition in generated index file when `glossaries[i].file` config is a glob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
glossarify-md.conf.json
Note: If
glossaries.fileis a glob patternglossaries.termHintandglossaries.titlewill be ignored.Related: #122