Enhance configs Prop in RangeDatepicker to Include monthsToDisplay #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt9142
changed the title
|
@nt9142 I got the idea what you are trying to do, there is a typescript error from the PR if you check it locally. Do you want me to fix it for you in this pr or handle it by yourself. And you need to export the props to the datepicker configs level. |
|
@aboveyunhai oops, my bad! I made sure the props are exported correctly. Can you give it another look? Thanks! |
|
@nt9142 lgtm, I also fixed some of my own typescript mistakes (since some of them misguide your code) if you're interested in taking a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new enhancement to the RangeDatepicker component. With this update, users can now specify the number of months they want to display in the datepicker.
This enhancement allows for greater flexibility when integrating the datepicker into various user interfaces, especially where space or user experience considerations might dictate displaying a different number of months.
Please review and let me know if any further changes are required.