Allow selected styling while being disabled #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aboveyunhai I just wanted to check in on this to see if you had thoughts about this PR and whether it may be worth moving forward. Thanks! |
I think it's fine. I will just merge it and see if ppl complaint about it, if so then turn into optional or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #76, this PR proposes to allow the selectedBtnProps even if a given dayOfMonth is disabled (e.g. being below minDate). The element remains disabled, both functionally and visually, yet allows the component to indicate that there is indeed a selected date (and/or likely range) that exists outside of the currently selectable/valid range.
An example of what this looks like is shown here:
I'd imagine this is closer to expected behavior, so don't think it's necessarily required to add additional props to allow this behavior sometimes, but am certainly open to that if you disagree.
Thanks for considering!