Skip to content

Commit

Permalink
Compatible with older dataTables versions.
Browse files Browse the repository at this point in the history
  • Loading branch information
maliming committed Mar 19, 2024
1 parent 48fda66 commit 06e4cfd
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ public class DatatablesNetScriptContributor : BundleContributor
{
public override void ConfigureBundle(BundleConfigurationContext context)
{
context.Files.AddIfNotContains("/libs/datatables.net/js/dataTables.min.js");
if (context.FileProvider.GetFileInfo("/libs/datatables.net/js/dataTables.min.js").Exists)
{
context.Files.AddIfNotContains("/libs/datatables.net/js/dataTables.min.js");
}

Check warning on line 16 in framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/DatatablesNet/DatatablesNetScriptContributor.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/DatatablesNet/DatatablesNetScriptContributor.cs#L14-L16

Added lines #L14 - L16 were not covered by tests
else
{

Check warning on line 18 in framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/DatatablesNet/DatatablesNetScriptContributor.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/DatatablesNet/DatatablesNetScriptContributor.cs#L18

Added line #L18 was not covered by tests
//TODO: Compatibility code, Remove it after 8.2 rc1.
context.Files.AddIfNotContains("/libs/datatables.net/js/jquery.dataTables.js");
}

Check warning on line 21 in framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/DatatablesNet/DatatablesNetScriptContributor.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/DatatablesNet/DatatablesNetScriptContributor.cs#L20-L21

Added lines #L20 - L21 were not covered by tests
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ var abp = abp || {};
* RECORD-ACTIONS extension for datatables *
*************************************************************************/
(function () {
if (!$.fn.dataTableExt) {
return;
}

var getVisibilityValue = function (visibilityField, record, tableInstance) {
if (visibilityField === undefined) {
return true;
Expand Down Expand Up @@ -234,9 +238,17 @@ var abp = abp || {};
var renderRowActions = function (tableInstance, nRow, aData, iDisplayIndex, iDisplayIndexFull) {
var columns;

var settings = tableInstance.api().settings();
if (settings.length === 1 && settings[0].aoColumns) {
columns = settings[0].aoColumns;
if (tableInstance.aoColumns) {
columns = tableInstance.aoColumns;
} else if (abp.utils.isFunction(tableInstance.fnSettings)) {
columns = tableInstance.fnSettings().aoColumns;
}

if (!columns && abp.utils.isFunction(tableInstance.api)) {
var settings = tableInstance.api().settings();
if (settings.length === 1 && settings[0].aoColumns) {
columns = settings[0].aoColumns;
}
}

if (!columns) {
Expand Down Expand Up @@ -266,6 +278,18 @@ var abp = abp || {};
}
};

if ($.fn.dataTableExt.oApi) {
var _existingApiRenderRowActionsFunction = $.fn.dataTableExt.oApi.renderRowActions;
$.fn.dataTableExt.oApi.renderRowActions =
function (tableInstance, nRow, aData, iDisplayIndex, iDisplayIndexFull) {
if (_existingApiRenderRowActionsFunction) {
_existingApiRenderRowActionsFunction(tableInstance, nRow, aData, iDisplayIndex, iDisplayIndexFull);
}

renderRowActions(tableInstance, nRow, aData, iDisplayIndex, iDisplayIndexFull);
};
}

if (!$.fn.dataTable) {
return;
}
Expand Down Expand Up @@ -451,10 +475,6 @@ var abp = abp || {};
if (column.rowAction) {
customizeRowActionColumn(column);
}

if (!column.type) {
column.type = "string";
}
}

configuration.language = datatables.defaultConfigurations.language();
Expand Down

0 comments on commit 06e4cfd

Please sign in to comment.