Merge pull request #10055 from abpframework/refactor/9952

Angular UI: Return observable from catchErrors
abpframework · Sep 16, 2021 · f6f1d5b · f6f1d5b
2 parents 75a270a + c511dd3
commit f6f1d5b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/npm/ng-packs/packages/core/src/lib/strategies/auth-flow.strategy.ts b/npm/ng-packs/packages/core/src/lib/strategies/auth-flow.strategy.ts
@@ -6,7 +6,7 @@ import {
   OAuthErrorEvent,
   OAuthInfoEvent,
   OAuthService,
-  OAuthStorage,
+  OAuthStorage
 } from 'angular-oauth2-oidc';
 import { from, Observable, of, pipe } from 'rxjs';
 import { filter, switchMap, tap } from 'rxjs/operators';
@@ -37,7 +37,10 @@ export abstract class AuthFlowStrategy {
   abstract logout(queryParams?: Params): Observable<any>;
   abstract login(params?: LoginParams | Params): Observable<any>;
 
-  private catchError = err => this.httpErrorReporter.reportError(err);
+  private catchError = err => {
+    this.httpErrorReporter.reportError(err);
+    return of(null);
+  };
 
   constructor(protected injector: Injector) {
     this.httpErrorReporter = injector.get(HttpErrorReporterService);

diff --git a/npm/ng-packs/packages/core/src/lib/utils/environment-utils.ts b/npm/ng-packs/packages/core/src/lib/utils/environment-utils.ts
@@ -1,5 +1,6 @@
 import { HttpClient } from '@angular/common/http';
 import { Injector } from '@angular/core';
+import { of } from 'rxjs';
 import { catchError, tap } from 'rxjs/operators';
 import { Environment, RemoteEnv } from '../models/environment';
 import { EnvironmentService } from '../services/environment.service';
@@ -19,7 +20,10 @@ export function getRemoteEnv(injector: Injector, environment: Partial<Environmen
   return http
     .request<Environment>(method, url, { headers })
     .pipe(
-      catchError(err => httpErrorReporter.reportError(err)), // TODO: Condiser get handle function from a provider
+      catchError(err => {
+        httpErrorReporter.reportError(err);
+        return of(null);
+      }), // TODO: Consider get handle function from a provider
       tap(env => environmentService.setState(mergeEnvironments(environment, env, remoteEnv))),
     )
     .toPromise();