-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual File System Explorer #1609
Comments
That is a good idea! It can be useful in development. Inject |
@hikalkan Also it seems it only returns physical files should it return files and directors from all three file providers memory, physical and dynamic ? |
It should return all, not only physical files. A sync method can directly usable inside an async method. Do you have any problem of that? |
No problem I thought that a ApplicationService should always return Async because the UI layer will call it using HttpAPI and whenever calling a HttpApi it should be done Async way as best practice ?? Is my understanding wrong ? |
You are true. However, not possible (or meaningfull) to make all methods async. BTW, this method is defined by Microsoft: https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.fileproviders.ifileprovider?view=aspnetcore-2.2 |
But the method I write in my application project should be Async right ? Should I just put a task.delay ?? |
No, not required. However, I suggest it. Never do task.delay :) Remove async keyword and return Task.CompletedTask; (for void methods) or Task.FromResult(...) (for method returns a value). |
thanks for your help that makes sense, I am not getting anything when I try and call I have changed the
|
@vnetonline can you create an issue for that so we check it. Thanks. |
Hi @vnetonline, |
@hikalkan I want to create a Virtual File System browser as a module
Can you let me know what your approach would be? It would be good to see what is in the Virtual File System when developing to override views and pages etc etc
Once developed happy for you to include it as a module in the repository.
The text was updated successfully, but these errors were encountered: