Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual File System Explorer Module #3971

Merged
merged 11 commits into from
May 23, 2020

Conversation

realLiangshiwei
Copy link
Member

Resolve #1609

Provide a simple page to view all virtual files.

Use:

[DependsOn(typeof(AbpVirtualFileExplorerWebModule))]
public class <YourProjectWebModule> : AbpModule

Options:

public class AbpVirtualFileExplorerOptions
{
     /// <summary>
     /// Default: true.
     /// </summary>
     public bool IsEnabled { get; set; } = true;
}

Demo:

image

image

@realLiangshiwei realLiangshiwei added this to the 2.8 milestone May 16, 2020
@hikalkan hikalkan self-requested a review May 19, 2020 21:12
@hikalkan
Copy link
Member

That's a great module! The only thing is: You embedded primjs into the module. However, using a NPM package would be great. As a result, this module will have a NPM package (just like https://github.com/abpframework/abp/blob/dev/npm/packs/docs/package.json). Its package name can be "@abp/virtual-file-explorer" Once the final application adds this package and runs yarn & gulp, prismjs will be added and perfectly works. You just need to use the PrismJs contributors.

@maliming can help you if you need?

@maliming maliming modified the milestones: 2.8, 2.9 May 20, 2020
@maliming
Copy link
Member

This requires some work and testing. Move to v2.9.

@maliming maliming modified the milestones: 2.9, 2.8 May 21, 2020
@maliming
Copy link
Member

@hikalkan We can release it in 2.8.

@kurtwilbies
Copy link

I dont like the naming, e.g. DemoApp.

@realLiangshiwei realLiangshiwei modified the milestones: 2.8, 2.9 May 21, 2020
@hikalkan hikalkan changed the title Virtual File System Explorer Virtual File System Explorer Module May 23, 2020
@hikalkan hikalkan merged commit f3a1bd6 into dev May 23, 2020
@hikalkan hikalkan deleted the liangshiwei/virtualfilesystem-explorer-module branch May 23, 2020 16:31
@hikalkan
Copy link
Member

Thanks a lot @liangshiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual File System Explorer
4 participants