Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Find PRO packages more accurate #16130

Closed
berkansasmaz opened this issue Mar 30, 2023 · 0 comments · Fixed by #16506
Closed

CLI: Find PRO packages more accurate #16130

berkansasmaz opened this issue Mar 30, 2023 · 0 comments · Fixed by #16506

Comments

@berkansasmaz
Copy link
Member

Related place:

public static bool IsCommercial(string packageId)

Reason:

public async Task<List<string>> GetPackageVersionListAsync(string packageId, bool includeNightly = false)
{
if (includeNightly)
{
return await GetPackageVersionsFromMyGet(packageId);
}
if (CommercialPackages.IsCommercial(packageId))
{
return await GetPackageVersionsFromAbpCommercialNuGetAsync(packageId);
}
else
{
var packagesFromNugetOrg = await GetPackageVersionsFromNuGetOrgAsync(packageId);
if (packagesFromNugetOrg != null)
{
return packagesFromNugetOrg;
}
}
return await GetPackageVersionsFromAbpCommercialNuGetAsync(packageId);
}

It first looks at nuget.org and then nuget.abp.io for commercial packages in the current structure. This causes performance issues.

In addition, it creates the perception that there is an error in the users.
Because when you can't find it on nuget.org, users will see an error like the one below:

HTTP request attempt failed to https://api.nuget.org/v3-flatcontainer/volo.abp.account.pro.admin.blazor.server/index.json with an error: 404-Not Found.

Related QA question: https://support.abp.io/QA/Questions/4756#answer-3a0a227c-488f-e4c5-29c3-5b8f1d686b84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants