Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovenian translations #2969

Closed
ebicoglu opened this issue Mar 4, 2020 · 5 comments
Closed

Add Slovenian translations #2969

ebicoglu opened this issue Mar 4, 2020 · 5 comments

Comments

@ebicoglu
Copy link
Member

ebicoglu commented Mar 4, 2020

Thanks to @leonkosak for Slovenian translations!

@ebicoglu ebicoglu added this to the 2.2 milestone Mar 4, 2020
@ebicoglu ebicoglu self-assigned this Mar 4, 2020
ebicoglu added a commit that referenced this issue Mar 4, 2020
@ebicoglu ebicoglu closed this as completed Mar 4, 2020
@sebitsi
Copy link

sebitsi commented Mar 6, 2020

Thanks @leonkosak for Slovenian translation.
As i can see from commits, there is only json files.

What about DB migrations ? Shouldn't be new (Slovenian) language added too ?

@leonkosak
Copy link
Contributor

@sebitsi Yes, all modules for abp (and Commercial) are distributed as NuGet packages and therefore the translations (.json) are inside packages.

The boilerplate code for language "initialization" is inside actual code. If you upgrade module/application, you have to manually add a new record in .cs code.

Example: #2671

When you run migrator, the language is also inserted in SQL database.

@sebitsi
Copy link

sebitsi commented Mar 11, 2020

Hi @leonkosak.
Thanks for your explanation.

I forgot to initialize language. :(

@leonkosak
Copy link
Contributor

@sebitsi are you from Slovenia?

@sebitsi
Copy link

sebitsi commented Mar 12, 2020

@leonkosak Yes I'm. You can contact me on edvin[at]sebit.si

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants