Failing tests of Identity Server module because of shared tempkey.rsa

[hikalkan]

System.IO.IOException : The process cannot access the file 'D:\Github\abp\modules\identityserver\test\Volo.Abp.IdentityServer.MongoDB.Tests\bin\Debug\netcoreapp3.1\tempkey.rsa' because it is being used by another process.

Is there any way to use an in-memory tempkey instead of a shared file?

[gterdem]

How can I reproduce this?

[maliming]

hi @gterdem

You can try using excel to open the tempkey.rsa file, or any editor that will lock the file. Then execute the dotnet test command in the identityserver module.

[maliming]

During unit testing, files may be locked by other unit tests.

[gterdem]

@maliming Thanks,
Because other parallel threads trying to access to file which is already in use. Ok, working on it.

[gterdem]

Well, easier way is seems not create tempkey.rsa by

if (builderOptions.AddDeveloperSigningCredential)
{
   identityServerBuilder = identityServerBuilder.AddDeveloperSigningCredential(false);
}

However this may cause clients to re-signin when identityserver is restarted as stated in this issue
The only in-memory RSA key generation and persisting can be done with a distributed cache which is not reasonable.

@hikalkan @maliming the best way is to override/set identityServerBuilder.AddDeveloperSigningCredential(false) at test modules.
I tried on PreConfigureServices and ConfigureServices of AbpIdentityServerTestBaseModule however I got no luck.
Is it possible to override only signingCredential?

[maliming]

hi @gterdem

Please refer to #1749 (comment)

[gterdem]

thanks @maliming
I tried it;
Once AddIdentityServer method of AbpIdentityServerDomainModule kicks in, tempkey.rsa is already created and it is used for validation.

PreConfigure<IIdentityServerBuilder>(identityServerBuilder =>
{
    identityServerBuilder.AddDeveloperSigningCredential(false);
});

Doesn't seem to be overriding the validator keys.

[maliming]

@gterdem Maybe this works.

public class AbpIdentityServerTestBaseModule : AbpModule
{
	public override void PreConfigureServices(ServiceConfigurationContext context)
	{
		PreConfigure<AbpIdentityServerBuilderOptions>(options =>
		{
			options.AddDeveloperSigningCredential = false;
		});
		
		PreConfigure<IIdentityServerBuilder>(identityServerBuilder =>
		{
			identityServerBuilder.AddDeveloperSigningCredential(persistKey: false, filename: Guid.NewGuid().ToString());
		});
	}
}

[gterdem]

@maliming Cheers.

Works pretty fine. Sent PR about it.