Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The method of razor page should return IActionResult #3495

Closed
maliming opened this issue Apr 7, 2020 · 2 comments · Fixed by #3579
Closed

The method of razor page should return IActionResult #3495

maliming opened this issue Apr 7, 2020 · 2 comments · Fixed by #3579
Assignees
@maliming
Labels
effort-1 enhancement
Milestone
2.6

Comments

@maliming
Copy link
Member

maliming commented Apr 7, 2020

Originally posted by @aklscv in #3464 (comment)
@maliming maliming mentioned this issue Apr 7, 2020
Closed
@maliming maliming self-assigned this Apr 7, 2020
@maliming maliming added this to the 2.5 milestone Apr 7, 2020
@maliming
Copy link
Member Author

maliming commented Apr 8, 2020

When developers want to customize some pages, such as redirect or return other types, they need IActionResult as the return value of Get/Post method.

@hikalkan What do you think?

@ebicoglu ebicoglu modified the milestones: 2.5, 2.6 Apr 10, 2020
@hikalkan
Copy link
Member

hikalkan commented Apr 12, 2020 •
edited

I agree. Returning IActionResult gives more opportunity while overriding.

maliming added a commit that referenced this issue Apr 13, 2020
@maliming
Use IActionResult as the return value of the page method in the module.
7583339 
#3495
@maliming maliming mentioned this issue Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliming maliming

Labels
effort-1 enhancement
Projects
None yet
Milestone
2.6
Development

Successfully merging a pull request may close this issue.

Use IActionResult as the return value of the page method in the module. abpframework/abp
3 participants
@hikalkan @maliming @ebicoglu