Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Template System #407

Closed
hikalkan opened this issue Sep 3, 2018 · 8 comments · Fixed by #3792
Closed

Text Template System #407

hikalkan opened this issue Sep 3, 2018 · 8 comments · Fixed by #3792

Comments

@hikalkan
Copy link
Member

hikalkan commented Sep 3, 2018

I've created a simple email template system to send localized emails with placeholders replaced by values on the runtime.

We can create a general-purpose templating system that can be integrated to templating existing libraries and play well with the Virtual File System and Localization features of ABP framework.

@hikalkan
Copy link
Member Author

hikalkan commented Sep 4, 2018

@natiki
Copy link
Contributor

natiki commented Sep 4, 2018

Something like https://github.com/andrewdavey/postal would also be ideal. It does HTML and Text very easily using Razor syntax. It has not had any work on it for some time though unfortunately even though it was promised andrewdavey/postal#172 (comment)

@bbakermmc
Copy link
Contributor

If its specif for email you should look at:
https://mjml.io/

@hikalkan
Copy link
Member Author

hikalkan commented Sep 5, 2018

I thought it as generic, but will look for mjml too. Thanks.

@hikalkan
Copy link
Member Author

This is implemented for email sending (#1141) using this library: https://github.com/lunet-io/scriban

I keep this issue open. We may generalize it to provide a more generic text templating feature.

@natiki
Copy link
Contributor

natiki commented May 28, 2019

@hikalkan how does scriban specifically deal with email templating? I don't see how it deals with plain text vs HTML templating etc.?

@maliming
Copy link
Member

hi @natiki

Scriban is an engine that processes text templates. So it can handle all the text of html, md, etc.

At the same time scriban is also a very active project, compatibility is also very good.
Support for advanced template syntax.

If you have other equally powerful text template engine class libraries, you can also replace it.

@natiki
Copy link
Contributor

natiki commented May 28, 2019

@maliming Understood.... Was just hoping that this would tie in easily to be able to use MVC to send emails like Postal or simlair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants