Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abp update command enhancement. #4225

Closed
maliming opened this issue Jun 5, 2020 · 4 comments · Fixed by #4387
Closed

abp update command enhancement. #4225

maliming opened this issue Jun 5, 2020 · 4 comments · Fixed by #4387
Assignees
@maliming
Labels
abp-cli effort-3 enhancement
Milestone
3.0

Comments

@maliming
Copy link
Member

maliming commented Jun 5, 2020 •
edited

We don't need to get the latest version of each package of Volo.Abp.xxx, we just need to use the latest version of Volo.Abp, because we always release all packages.

This will save a lot of time.

[14:21:05 INF] Updating package "Volo.Abp.BackgroundJobs.Domain" from v2.8.0 to v2.9.0.
[14:21:06 INF] Updating package "Volo.Abp.AuditLogging.Domain" from v2.8.0 to v2.9.0.
[14:21:08 INF] Updating package "Volo.Abp.TenantManagement.Domain" from v2.8.0 to v2.9.0.
[14:21:09 INF] Updating package "Volo.Abp.FeatureManagement.Domain" from v2.8.0 to v2.9.0.
[14:21:10 INF] Updating package "Volo.Abp.SettingManagement.Domain" from v2.8.0 to v2.9.0.
[14:21:11 INF] Updating package "Volo.Abp.Identity.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:13 INF] Updating package "Volo.Abp.IdentityServer.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:14 INF] Updating package "Volo.Abp.BackgroundJobs.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:15 INF] Updating package "Volo.Abp.AuditLogging.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:16 INF] Updating package "Volo.Abp.TenantManagement.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:18 INF] Updating package "Volo.Abp.FeatureManagement.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:19 INF] Updating package "Volo.Abp.PermissionManagement.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:20 INF] Updating package "Volo.Abp.SettingManagement.Domain.Shared" from v2.8.0 to v2.9.0.
[14:21:21 INF] Updating package "Volo.Abp.EntityFrameworkCore.SqlServer" from v2.8.0 to v2.9.0.
[14:21:23 INF] Updating package "Volo.Abp.PermissionManagement.EntityFrameworkCore" from v2.8.0 to v2.9.0.
[14:21:24 INF] Updating package "Volo.Abp.SettingManagement.EntityFrameworkCore" from v2.8.0 to v2.9.0.
@maliming maliming self-assigned this Jun 5, 2020
@maliming maliming added this to the 3.0 milestone Jun 5, 2020
@maliming
Copy link
Member Author

maliming commented Jun 5, 2020

@hikalkan What do you think?

@talhazengin
Copy link

We encountered a situation before which you just updated only a package and not all the packages.

@hikalkan
Copy link
Member

@maliming, you are right, we generally publish all together. But, there are rare cases we only publish a single package patch. I don't want to restrict us and place such a strict rule for just this case. If we later dedice forbid publishing individual packages (because of some strong reasons), we revisit this case and update the CLI.

@hikalkan
Copy link
Member

What about that:

  1. We can only check the Volo.Abp.Core package by default and provide an option like --check-all for advanced cases. This will OK for most of the cases.
  2. We can check packages in parallel (multi-threading) to save performance if we set --check-all.

What do you think?

maliming added a commit that referenced this issue Jun 18, 2020
@maliming
abp update command enhancement(--check-all).
d8cc28b 
Resolve #4225
@maliming maliming mentioned this issue Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliming maliming

Labels
abp-cli effort-3 enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

abp update command enhancement(--check-all). abpframework/abp
3 participants
@hikalkan @maliming @talhazengin