Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest:Remove invalid log in AbpExceptionFilter #4949

Closed
fmpfmp opened this issue Aug 4, 2020 · 1 comment · Fixed by #4950
Closed

Suggest:Remove invalid log in AbpExceptionFilter #4949

fmpfmp opened this issue Aug 4, 2020 · 1 comment · Fixed by #4950
Assignees
Milestone

Comments

@fmpfmp
Copy link
Contributor

fmpfmp commented Aug 4, 2020

I use "Volo.Abp.AspNetCore.Serilog" to write log into Exceptionless;

When a exception is throw,AbpExceptionFilter will write 4 error log,and this logs are meaningless;

So, I suggest: remove invalid log in AbpExceptionFilter, or set this logs with “Debug” or "Verbose"

Level  Log  Time
Error   AbpExceptionFilter :@exceptionless 13 小时前
 Error   AbpExceptionFilter : ---------- Exception Data ----------   13 小时前
 Error   AbpExceptionFilter : { "code": null, "message": "An internal error occurred during your request!", "details": null, "validationErrors": null }   13 小时前
 Error   AbpExceptionFilter : ---------- RemoteServiceErrorInfo ---------- 13 小时前
@maliming
Copy link
Member

maliming commented Aug 4, 2020

We should consider combining those logs into one.

@maliming maliming self-assigned this Aug 4, 2020
@maliming maliming added this to the 3.1 milestone Aug 4, 2020
maliming added a commit that referenced this issue Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants