Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation extension property table header should be localized #6834

Closed
hikalkan opened this issue Dec 27, 2020 · 2 comments · Fixed by #6859
Closed

Navigation extension property table header should be localized #6834

hikalkan opened this issue Dec 27, 2020 · 2 comments · Fixed by #6859
Assignees
Milestone

Comments

@hikalkan
Copy link
Member

Prop definition:

ObjectExtensionManager.Instance.Modules()
    .ConfigureIdentity(identity =>
    {
        identity.ConfigureUser(user =>
        {
            user.AddOrUpdateProperty<Guid>(
                "PrimaryRoleId",
                property =>
                {
                    property.UI.Lookup.Url = "/api/identity/roles";
                    property.UI.Lookup.DisplayPropertyName = "name";
                }
            );
        });
    });

Localization:

"DisplayName:PrimaryRoleId": "Primary Role"

Create/Edit modal:

image

Properly localized.

UI Table:

image

Not localized. It should be localized with the same rules.

@ilkayilknur
Copy link
Contributor

This is the fix for the issue. #6834 This change could break the Angular side, or the issue may exist on the Angular side as well. I will talk to @armanozak tomorrow.

@ilkayilknur
Copy link
Contributor

Fixed #6859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants