Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize IdentityServer data access on token request #6969

Closed
hikalkan opened this issue Jan 3, 2021 · 0 comments · Fixed by #7856
Closed

Optimize IdentityServer data access on token request #6969

hikalkan opened this issue Jan 3, 2021 · 0 comments · Fixed by #7856
Assignees
@maliming
Labels
abp-module-identityserver effort-3 enhancement priority:normal
Milestone
4.3-preview

Comments

@hikalkan
Copy link
Member

hikalkan commented Jan 3, 2021

When we request access token from IDS endpoint, it performs 6-7 database queries. We can try to optimize these database operations. For example, we may exclude details while querying where it is not needed or try to reduce queries if possible.

Note: Adding app.UseUnitOfWork() middleware before app.UseIdentityServer() (#6968) helps to reduce DbContext creation. However, I think we can optimize it more.
@hikalkan hikalkan added this to the 4.3-preview milestone Jan 3, 2021
maliming added a commit that referenced this issue Jan 25, 2021
@maliming
Add an option to enable memory cache for ids module.
f41bf9a 
Resolve #6969
@maliming maliming mentioned this issue Jan 25, 2021
Closed
maliming added a commit that referenced this issue Feb 25, 2021
@maliming
Use IDistributedCache in AbpCorsPolicyService,ClientStore,ResourceStore.
7cc725f 
Resolve #6969
https://identityserver4.readthedocs.io/en/latest/reference/options.html#caching
@maliming maliming mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliming maliming

Labels
abp-module-identityserver effort-3 enhancement priority:normal
Projects
None yet
Milestone
4.3-preview
2 participants
@hikalkan @maliming