Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CorrelationId #738

Closed
hikalkan opened this issue Jan 17, 2019 · 3 comments
Closed

Implement CorrelationId #738

hikalkan opened this issue Jan 17, 2019 · 3 comments

Comments

@hikalkan
Copy link
Member

That is passed between service calls to track the same request/operation/transaction. It's also logged.

@natiki
Copy link
Contributor

natiki commented Feb 11, 2019

Hi @hikalkan,

I just want to put forward that in all likelihood the microservices will be running in something like https://konghq.com/. The OSS version is very powerful. That is how I run things because it gives me a native K8s solution and does so many things more than correlation ID's https://docs.konghq.com/hub/kong-inc/correlation-id/. Might also then be worth a discussion as to what ABP needs to do in terms of a microservice framework.

It can do request transforms, security, logging etc etc. So if you could consider that the microservices will actually be written using ABP but not necessarily using the ABP workflow that would be great.

@natiki
Copy link
Contributor

natiki commented Feb 19, 2019

@hikalkan Interested in your comments based on my comment #738 (comment)

@hikalkan
Copy link
Member Author

Hi @natiki,

ABP has no goal to be a complete microservice framework & solution. It is better to integrate/use existing popular tools and libraries. Our goal is to be compatible to different tools (but will not have direct integrations to all of them). And our main goal is to develop the framework & modules as microservice compatible, and even ms focused. For this purpose, we defined a module specification and basic framework features.

For instance, if you are using a service mesh or logging system that has a CorrelationId feature, just forget about using ABP's feature, or integrate it by just implementing ICorrelationIdProvider, it is flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants