Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct naming of ApiScopeRepository.GetByName method. #10053

Merged
merged 2 commits into from Sep 20, 2021

Conversation

PMExtra
Copy link
Contributor

@PMExtra PMExtra commented Sep 16, 2021

public async Task<ApiScope> GetByNameAsync(string scopeName, bool includeDetails = true, CancellationToken cancellationToken = default)
{
return await (await GetDbSetAsync())
.OrderBy(x=>x.Id)
.FirstOrDefaultAsync(x => x.Name == scopeName, GetCancellationToken(cancellationToken));
}

The method was implementation like FindByNameAsync, it will return null instead of throw an exception when the entity was not found.

This PR will correct its name. Notice that this is a breaking change, it may should be merged in next major version.

The method was implementation like FindByName, this commit will correct its name.
@maliming maliming self-requested a review September 16, 2021 11:58
@maliming maliming added this to the 5.0-preview milestone Sep 16, 2021
@maliming maliming self-assigned this Sep 17, 2021
@maliming maliming merged commit 306c81c into abpframework:dev Sep 20, 2021
@maliming
Copy link
Member

Thanks @PMExtra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants