Angular UI: Move ChartComponent to @abp/ng.components/chart.js #10082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7472
Chart.js is lazy-loaded by
@abp/theme.shared
after app initialization (before v5.0). Loading the chart.js is redundant if you don't use theChartComponent
. So we handled this case and decided to moveChartComponent
to another package (@abp/ng.components/chart.js
). As of v5.0, if you do not importChartModule
, thechart.js
script will not be loaded.In this PR, there are some changes that may break your app:
ChartModule
to use theabp-chart
as shown below:chartJsLoaded$
subject has been removedgetRandomBackgroundColor
function moved to@abp/ng.components/chart.js