Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load script/style asynchronously. #10317

Merged
merged 3 commits into from Oct 25, 2021
Merged

Load script/style asynchronously. #10317

merged 3 commits into from Oct 25, 2021

Conversation

maliming
Copy link
Member

Resolve #10306

<abp-script defer="true" src="/Pages/Index.js" />

<abp-script-bundle defer="true">
    <abp-script src="/Pages/Index.js" />
</abp-script-bundle>

Configure<AbpTagHelperScriptStyleLoadingOptions>(options =>
{
    options.PreloadStyles.Add("/__bundles/Basic.Global");
});

@maliming maliming added this to the 5.0-preview milestone Oct 14, 2021
@hikalkan
Copy link
Member

Please create an issue about the documentation update and send a PR for it separately.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10317 (7daaeeb) into dev (2f28080) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #10317      +/-   ##
==========================================
- Coverage   54.74%   54.72%   -0.03%     
==========================================
  Files        2639     2639              
  Lines       75272    75307      +35     
==========================================
  Hits        41208    41208              
- Misses      34064    34099      +35     
Impacted Files Coverage Δ
...p/AspNetCore/Mvc/UI/Bundling/AbpBundlingOptions.cs 0.00% <0.00%> (ø)
...ndling/TagHelpers/AbpBundleItemTagHelperService.cs 0.00% <0.00%> (ø)
...I/Bundling/TagHelpers/AbpBundleTagHelperService.cs 0.00% <0.00%> (ø)
...UI/Bundling/TagHelpers/AbpScriptBundleTagHelper.cs 0.00% <0.00%> (ø)
...e/Mvc/UI/Bundling/TagHelpers/AbpScriptTagHelper.cs 0.00% <0.00%> (ø)
.../UI/Bundling/TagHelpers/AbpStyleBundleTagHelper.cs 0.00% <0.00%> (ø)
...re/Mvc/UI/Bundling/TagHelpers/AbpStyleTagHelper.cs 0.00% <0.00%> (ø)
...Bundling/TagHelpers/AbpTagHelperResourceService.cs 0.00% <0.00%> (ø)
...I/Bundling/TagHelpers/AbpTagHelperScriptService.cs 0.00% <0.00%> (ø)
...UI/Bundling/TagHelpers/AbpTagHelperStyleService.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f28080...7daaeeb. Read the comment docs.

@hikalkan hikalkan merged commit b8931b4 into dev Oct 25, 2021
@hikalkan hikalkan deleted the maliming/async-load branch October 25, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load script/style asynchronously.
3 participants