Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DynamicJavaScriptProxyOptions #10370

Merged
merged 7 commits into from Oct 25, 2021
Merged

Introduce DynamicJavaScriptProxyOptions #10370

merged 7 commits into from Oct 25, 2021

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Oct 20, 2021

Resolve #9955, #10419

I used disabled mode, dynamic proxy is enabled by default, we manually disable it in the module.

For developers, they don’t need to change anything when they upgrade to 5.0, the dynamic proxy is still works.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev@9138aad). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #10370   +/-   ##
======================================
  Coverage       ?   54.72%           
======================================
  Files          ?     2641           
  Lines          ?    75338           
  Branches       ?        0           
======================================
  Hits           ?    41229           
  Misses         ?    34109           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9138aad...f6977bb. Read the comment docs.

@realLiangshiwei realLiangshiwei marked this pull request as ready for review October 21, 2021 08:49
@hikalkan hikalkan self-requested a review October 24, 2021 10:22
@hikalkan
Copy link
Member

We are also moving the profile service from identity to account. I think you're doing that because the UI is in the account part, right? Please create an annoucement about that breaking change and the reason. Can you also make same for the abp-commercial? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce option to enable/disable dynamic JavaScript proxies per module
2 participants