Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change virtual keyword order #10398

Merged
merged 1 commit into from
Oct 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public AbpPageToolbarViewComponent(IPageToolbarManager toolbarManager)
ToolbarManager = toolbarManager;
}

public async Task<IViewComponentResult> InvokeAsync(string pageName)
public virtual async Task<IViewComponentResult> InvokeAsync(string pageName)
{
var items = await ToolbarManager.GetItemsAsync(pageName);
return View("~/Pages/Shared/Components/AbpPageToolbar/Default.cshtml", items);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public MainNavbarMenuViewComponent(IMenuManager menuManager)
MenuManager = menuManager;
}

public async virtual Task<IViewComponentResult> InvokeAsync()
public virtual async Task<IViewComponentResult> InvokeAsync()
{
var menu = await MenuManager.GetMainMenuAsync();
return View("~/Themes/Basic/Components/Menu/Default.cshtml", menu);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public LanguageSwitchViewComponent(ILanguageProvider languageProvider)
LanguageProvider = languageProvider;
}

public async virtual Task<IViewComponentResult> InvokeAsync()
public virtual async Task<IViewComponentResult> InvokeAsync()
{
var languages = await LanguageProvider.GetLanguagesAsync();
var currentLanguage = languages.FindByCulture(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public MainNavbarToolbarViewComponent(IToolbarManager toolbarManager)
ToolbarManager = toolbarManager;
}

public async virtual Task<IViewComponentResult> InvokeAsync()
public virtual async Task<IViewComponentResult> InvokeAsync()
{
var toolbar = await ToolbarManager.GetAsync(StandardToolbars.Main);
return View("~/Themes/Basic/Components/Toolbar/Default.cshtml", toolbar);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public UserMenuViewComponent(IMenuManager menuManager)
MenuManager = menuManager;
}

public async virtual Task<IViewComponentResult> InvokeAsync()
public virtual async Task<IViewComponentResult> InvokeAsync()
{
var menu = await MenuManager.GetAsync(StandardMenus.User);
return View("~/Themes/Basic/Components/Toolbar/UserMenu/Default.cshtml", menu);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public TagEditorViewComponent(ITagAppService tagAppService)
TagAppService = tagAppService;
}

public async Task<IViewComponentResult> InvokeAsync(string entityType, string entityId, bool displaySubmitButton = true)
public virtual async Task<IViewComponentResult> InvokeAsync(string entityType, string entityId, bool displaySubmitButton = true)
{
var tags =
entityId.IsNullOrWhiteSpace() ?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public EmailSettingGroupViewComponent(IEmailSettingsAppService emailSettingsAppS
EmailSettingsAppService = emailSettingsAppService;
}

public async virtual Task<IViewComponentResult> InvokeAsync()
public virtual async Task<IViewComponentResult> InvokeAsync()
{
var model = await EmailSettingsAppService.GetAsync();

Expand Down