Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit issues in Blazor Server. #10570

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix audit issues in Blazor Server. #10570

merged 2 commits into from
Nov 11, 2021

Conversation

maliming
Copy link
Member

@maliming maliming commented Nov 9, 2021

Resolve #10527

a2e5fae64284f34ed0ad8c05bcb3053

image

@maliming maliming added this to the 5.0-preview milestone Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #10570 (c0206ba) into dev (045c5e6) will decrease coverage by 0.08%.
The diff coverage is 0.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #10570      +/-   ##
==========================================
- Coverage   54.76%   54.67%   -0.09%     
==========================================
  Files        2647     2652       +5     
  Lines       75564    75686     +122     
==========================================
+ Hits        41382    41384       +2     
- Misses      34182    34302     +120     
Impacted Files Coverage Δ
...p/AspNetCore/SignalR/AbpAspNetCoreSignalRModule.cs 0.00% <0.00%> (ø)
...gnalR/Volo/Abp/AspNetCore/SignalR/AbpHubContext.cs 0.00% <0.00%> (ø)
...pNetCore/SignalR/AbpHubContextAccessorHubFilter.cs 0.00% <0.00%> (ø)
...p/AspNetCore/SignalR/Auditing/AbpAuditHubFilter.cs 0.00% <0.00%> (ø)
...R/Auditing/AspNetCoreSignalRAuditLogContributor.cs 0.00% <0.00%> (ø)
...gnalR/Authentication/AbpAuthenticationHubFilter.cs 0.00% <ø> (ø)
...AspNetCore/SignalR/DefaultAbpHubContextAccessor.cs 0.00% <0.00%> (ø)
...pNetCore/Auditing/AspNetCoreAuditLogContributor.cs 91.83% <33.33%> (-3.82%) ⬇️
...ttp/Client/DynamicProxying/ApiDescriptionFinder.cs 87.35% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c1096...c0206ba. Read the comment docs.

@hikalkan hikalkan merged commit d408fa0 into dev Nov 11, 2021
@hikalkan hikalkan deleted the maliming/AbpAuditHubFilter branch November 11, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityHistory - AbpDbContext don't save changes
2 participants