Docs multi language #1180
Merged
Docs multi language #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
requested changes
May 30, 2019
| input.Version | ||
| ); | ||
| } | ||
|
|
||
| public async Task<DocumentResourceDto> GetResourceAsync(GetDocumentResourceInput input) | ||
| { | ||
| var project = await _projectRepository.GetAsync(input.ProjectId); | ||
| var cacheKey = $"Resource@{project.ShortName}#{input.Name}#{input.Version}"; | ||
| var cacheKey = $"Resource@{project.ShortName}#{input.LanguageCode}#{input.Name}#{input.Version}"; |
There was a problem hiding this comment.
What if input.LanguageCode is null?
| @@ -92,20 +99,23 @@ async Task<DocumentResourceDto> GetResourceAsync() | |||
| ); | |||
| } | |||
|
|
|||
| protected virtual async Task<DocumentWithDetailsDto> GetDocumentWithDetailsDto( | |||
| protected virtual async Task<DocumentWithDetailsDto> GetDocument( | |||
There was a problem hiding this comment.
Rename ro GetDocumentWithDetailsDtoAsync
| { | ||
| var language = languageCodes.Languages.FirstOrDefault(l => l.Code == languageCode); | ||
|
|
||
| return language ?? languageCodes.Languages.Single(l => l.IsDefault); |
There was a problem hiding this comment.
Throw a better exception if default language is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #482