Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Component Feature to ExtensibleForm. #13700

Merged
merged 15 commits into from
Aug 29, 2022
Merged

Add Custom Component Feature to ExtensibleForm. #13700

merged 15 commits into from
Aug 29, 2022

Conversation

mahmut-gundogdu
Copy link
Contributor

@mahmut-gundogdu mahmut-gundogdu commented Aug 15, 2022 •
edited

Resolves #13785

Test Preparation

  • go to npm>ng_packs and run yarn run build:all
  • run backend with extra-properties
  • run ng-packs/dev-app.

Test steps

  • my-profile page re-written with extensible form. So it should work as before. All functionality that in my-profile should be tested.
  • Add extra properties on Backend (https://docs.abp.io/en/abp/latest/Module-Entity-Extensions)
  • The extra properties should visible and changeable on the profile page.

the task related to #13700

@mahmut-gundogdu mahmut-gundogdu added this to the 6.0-final milestone Aug 15, 2022
@mahmut-gundogdu mahmut-gundogdu added the hold Taken progress, but needs to wait something. label Aug 16, 2022
@mahmut-gundogdu mahmut-gundogdu changed the base branch from dev to rel-6.0 August 16, 2022 11:49
@realLiangshiwei realLiangshiwei mentioned this pull request Aug 18, 2022
Closed
@mahmut-gundogdu mahmut-gundogdu marked this pull request as ready for review August 19, 2022 11:29
@mahmut-gundogdu mahmut-gundogdu removed the hold Taken progress, but needs to wait something. label Aug 19, 2022
@gizemmutukurt gizemmutukurt requested review from gizemmutukurt and removed request for gizemmutukurt August 22, 2022 06:38
@gizemmutukurt
Copy link
Contributor

I requested some fixes and changes, you can check it out.

#13785

gizemmutukurt
gizemmutukurt requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@gizemmutukurt gizemmutukurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some fixes and changes

muhammedaltug
muhammedaltug reviewed Aug 25, 2022
View reviewed changes
npm/ng-packs/packages/account/src/lib/guards/extensions.guard.ts Outdated Show resolved Hide resolved
npm/ng-packs/packages/core/src/lib/validators/username.validator.ts Outdated Show resolved Hide resolved
...theme-shared/extensions/src/lib/components/extensible-form/extensible-form-prop.component.ts Outdated Show resolved Hide resolved
...ages/theme-shared/extensions/src/lib/components/extensible-form/extensible-form.component.ts Outdated Show resolved Hide resolved
npm/ng-packs/packages/theme-shared/extensions/src/lib/models/form-props.ts Outdated Show resolved Hide resolved
npm/ng-packs/packages/theme-shared/extensions/src/lib/models/props.ts Outdated Show resolved Hide resolved
npm/ng-packs/packages/theme-shared/extensions/src/lib/tokens/extensions.token.ts Outdated Show resolved Hide resolved
@gizemmutukurt gizemmutukurt merged commit 2508aea into rel-6.0 Aug 29, 2022
@gizemmutukurt gizemmutukurt deleted the issue-11401 branch August 29, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammedaltug muhammedaltug muhammedaltug approved these changes

@gizemmutukurt gizemmutukurt gizemmutukurt approved these changes

Assignees
No one assigned
Labels
ui-angular
Projects
None yet
Milestone
6.0-final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mahmut-gundogdu @gizemmutukurt @muhammedaltug