Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all date range inputs to daterange picker mvc] #13793 #14017

Merged

Conversation

salihozkara
Copy link
Member

Resolves #13793

@salihozkara salihozkara marked this pull request as draft September 14, 2022 11:33
@salihozkara salihozkara marked this pull request as ready for review September 15, 2022 07:48
@gizemmutukurt gizemmutukurt added this to the 7.0-preview milestone Sep 15, 2022
@rqx110
Copy link
Contributor

rqx110 commented Sep 16, 2022

since we are using DateRangePicker component, why still using SingleDatePicker style in cms-kit and doc module?

@gizemmutukurt
Copy link
Contributor

gizemmutukurt commented Sep 16, 2022

The error I get in the doc module I run in the volo repo is as follows
image

@salihozkara
Copy link
Member Author

since we are using DateRangePicker component, why still using SingleDatePicker style in cms-kit and doc module?

because the start and end dates are left optional, for example, only the end date is left as selectable.

@ebicoglu
Copy link
Member

since we are using DateRangePicker component, why still using SingleDatePicker style in cms-kit and doc module?

as @salihozkara said, when the start & end date are optional, we cannot use DateRangePicker. Because this tool doesn't have an optional date selection.

@enisn
Copy link
Member

enisn commented Sep 16, 2022

The error I get in the doc module I run in the volo repo is as follows image

abp install-libs should solve that

@gizemmutukurt
Copy link
Contributor

gizemmutukurt commented Sep 16, 2022

The error I get in the doc module I run in the volo repo is as follows image

abp install-libs should solve that

Since two folders(moment and bootstrap-daterangepicker) are missing in the libs file under wwwroot, the abp install-libs command was not enough to fix the error. When the time comes, @salih will add the relevant folders.

@ebicoglu
Copy link
Member

fix the conflicts

@salihozkara
Copy link
Member Author

The error I get in the doc module I run in the volo repo is as follows image

abp install-libs should solve that

libs.zip You can get rid of the error by throwing the two folders under the libs folder in the zip under the wwwroot/libs folder under the web project you are running.

@ebicoglu ebicoglu merged commit 63ad2ca into dev Sep 20, 2022
@ebicoglu ebicoglu deleted the Replace-all-date-range-inputs-to-daterange-picker-MVC]-#13793 branch September 20, 2022 06:25
@salihozkara salihozkara restored the Replace-all-date-range-inputs-to-daterange-picker-MVC]-#13793 branch November 15, 2022 06:56
@salihozkara salihozkara deleted the Replace-all-date-range-inputs-to-daterange-picker-MVC]-#13793 branch September 26, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all date range inputs to daterange picker [MVC]
5 participants